Summary

Make manual build

Review Request #8586 — Created Jan. 1, 2017 and discarded Jan. 11, 2017, 11:27 a.m.

Information

Owner

erijo

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix the sys.path set up to point to the current working copy of review
board. Without this, the build of docs.db fails with:

ImportError: Could not import settings 'reviewboard.settings'

Also add the GitHub hosting service referenced in initial_data.json. Without
this, the build fails with:

CRITICAL:root:Resource "<class
'reviewboard.webapi.resources.hosting_service.HostingServiceResource'>"
requires objects in the database

Testing Done

make html now works. Didn't before this.

Tool: Pyflakes
Processed Files:
    docs/manual/_ext/webapidocs.py
    docs/manual/docsmanage.py



Tool: PEP8 Style Checker
Processed Files:
    docs/manual/_ext/webapidocs.py
    docs/manual/docsmanage.py

Hmm, we have make html working fine, locally and on build machines. I suspect there's just a setup error in your development environment. Particularly if you have to register the hosting service and change paths. How did you prepare the environment for development? Are you using virtualenvs?

erijo Jan. 11, 2017, 11:27 a.m.

Seems to be working fine for me now as well, don't know what I did wrong earlier. As you said, probably something in my environment. Discarding this, but you might want to consider picking the sys.path changes as what was before seems wrong, even if it works.

Sorry for the noise.

Status:: Discarded