Fix specifying command line arguments with Unicode characters.
Review Request #8559 — Created Nov. 30, 2016 and submitted
RBTools would crash when Unicode characters were specified on the command line, due to a logging statement that tried converting the byte strings into a Unicode string. This was happening because our RBT_MAIN constant was a Unicode string, and thus all remaining strings in argv were being converted (improperly) to Unicode as well. This changes RBT_MAIN to be a byte string, allowing string concatenation to work properly. It also fixes some argument lookups and the logging statement to properly decode to a Unicode string.
Posted a change using Chinese characters as the review request description.
Instead of errors and crashes, I got proper debug output and the change
posted.
| Description | From | Last Updated |
|---|---|---|
|
Hi, I'm encounter this issue with RBTool 0.7.7, does this patch already released in 0.7.7 or not? |
BI billhoo |
Tool: Pyflakes Processed Files: rbtools/commands/main.py rbtools/commands/__init__.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/main.py rbtools/commands/__init__.py