Fix API tests which rely on required_features.
Review Request #8550 — Created Nov. 21, 2016 and submitted
When an API resource depends on a feature, tests for it would pass or fail
depending on whether that feature was enabled insettings_local.py. Because
tests are there to test the actual behavior, we want to override the feature
status to enable it always.This change does that, and fixes up the various mixins and top-level tests to
work correctly. I haven't added any extra tests to specific resources to verify
the API output when the feature(s) are disabled, because those are tested more
generically with a dummy resource and feature.
Disabled the status updates feature in my
settings_local.pyand ran unit
tests. Before this change, all the status updates tests failed. After, they
pass.
Tool: Pyflakes Processed Files: reviewboard/webapi/tests/mixins.py reviewboard/reviews/tests/test_review_request.py reviewboard/webapi/tests/mixins_extra_data.py reviewboard/webapi/tests/test_status_update.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/mixins.py reviewboard/reviews/tests/test_review_request.py reviewboard/webapi/tests/mixins_extra_data.py reviewboard/webapi/tests/test_status_update.py