• 
      

    Fix installing dependencies on Python 2.6.

    Review Request #8544 — Created Nov. 17, 2016 and submitted

    Information

    Djblets
    release-0.8.x
    ddfba58...

    Reviewers

    Python 2.6 doesn't provide subprocess.check_output, which we use to
    determine whether we can call certain looks (like npm) during package
    dependency installation. An alternative is subprocess.check_call, which
    works but outputs results to stdout, and isn't as nice as check_output
    for our purposes.

    This change conditionally chooses which call to make, based on the
    version of Python. On 2.7, we use the nicer check_output, whereas on
    2.7, we use the less-nice-but-still-suitable check_call.

    Installed dependencies on both Python 2.6 and 2.7.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          setup.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          setup.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.8.x (2ca9123)