• 
      

    Fix parsing binary diffs in CVS.

    Review Request #8540 — Created Nov. 15, 2016 and submitted

    Information

    Review Board
    release-2.0.x
    19e8897...

    Reviewers

    Recent releases made changes to CVS diff parsing, which caused a crash
    when parsing binary diffs. Before, binary diffs weren't really handled
    specially (they weren't marked as binary diffs), but they at least
    didn't crash.
    
    This change implements proper parsing of binary diffs. It now looks for
    the binary indicator and sets the appropriate flag, and computes the
    correct filenames for the original and modified files.

    Unit tests pass.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/scmtools/cvs.py
          reviewboard/scmtools/tests/test_cvs.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/scmtools/cvs.py
          reviewboard/scmtools/tests/test_cvs.py
      
      
    2. 
        
    chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/scmtools/cvs.py
          reviewboard/scmtools/tests/test_cvs.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (9e000d0)