Fix js-tests.
Review Request #8538 — Created Nov. 14, 2016 and submitted
Several failures had snuck into the js-tests suite, with varying degrees of
awfulness. Most of these are just places where the code had been refactored or
changed without updating the tests correctly, or where code had been merged
that used the older API.The major issue was in the
reviewablePageViewTests.jsfile, where a failed
expectation result involved some objects with a circular reference. Jasmine was
attempting to print this, which caused an infinite recursion and corresponding
browser hang (or even crash). I've changed the expectation to be a bit more
specific, which works around this particular failure.
Ran js-tests.
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/tests/commentDialogViewTests.js reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.js reviewboard/static/rb/js/views/tests/reviewBoxViewTests.js reviewboard/static/rb/js/pages/views/tests/reviewablePageViewTests.js reviewboard/static/rb/js/views/tests/reviewViewTests.es6.js reviewboard/static/rb/js/ui/views/dialogView.es6.js reviewboard/static/rb/js/models/tests/uploadDiffModelTests.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/tests/commentDialogViewTests.js reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.js reviewboard/static/rb/js/views/tests/reviewBoxViewTests.js reviewboard/static/rb/js/pages/views/tests/reviewablePageViewTests.js reviewboard/static/rb/js/views/tests/reviewViewTests.es6.js reviewboard/static/rb/js/ui/views/dialogView.es6.js reviewboard/static/rb/js/models/tests/uploadDiffModelTests.js