Modernize the guides on creating extensions.

Review Request #8523 — Created Nov. 5, 2016 and submitted

Information

Review Board
release-2.5.x
9efb29a...

Reviewers

This fleshes out the various pages on creating extensions. There's now a
new, fully-detailed walkthrough of the extension class and the
attributes/methods that need to be used. The guides to the file/package
layout and packaging have been updated to talk about Wheels, static
media bundling, dependencies, etc. The configuration and static media
pages go into more details on the options available, along with
examples. The database models page now talks about writing evolution
files.

The resulting documentation is now a lot more clear, helping truly guide
extension authors to getting started. It should be easier for us to
continue to maintain and update as we go forward.

Built the docs and went through them, checking for spelling errors (though
it's possible I missed some), links, source code, etc.

(Some links are currently broken, just because there are some new pages that
aren't part of this change.)

Description From Last Updated

We should probably recommend as a best practice that the version only be defined in the package metadata because people …

daviddavid

Can you add an import line for the resource instances to this code block?

daviddavid

Should say "raised" instead of "thrown"

daviddavid

Too many spaces between sentences here.

daviddavid

Can we add a warning to never use --hint --execute?

daviddavid

"compiled down" is weird. How about just "compiled to CSS"?

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        docs/manual/conf.py
    
    Ignored Files:
        docs/manual/extending/extensions/file-layout.rst
        docs/manual/extending/extensions/static-files.rst
        docs/manual/glossary.rst
        docs/manual/extending/extensions/distribution.rst
        docs/manual/extending/extensions/models.rst
        docs/manual/extending/extensions/configuration.rst
        docs/manual/extending/extensions/class.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        docs/manual/conf.py
    
    Ignored Files:
        docs/manual/extending/extensions/file-layout.rst
        docs/manual/extending/extensions/static-files.rst
        docs/manual/glossary.rst
        docs/manual/extending/extensions/distribution.rst
        docs/manual/extending/extensions/models.rst
        docs/manual/extending/extensions/configuration.rst
        docs/manual/extending/extensions/class.rst
    
    
  2. 
      
david
  1. Great change!

  2. docs/manual/extending/extensions/class.rst (Diff revision 1)
     
     
     
     
     
    Show all issues

    We should probably recommend as a best practice that the version only be defined in the package metadata because people will forget.

  3. docs/manual/extending/extensions/class.rst (Diff revision 1)
     
     
     
     
     
     
    Show all issues

    Can you add an import line for the resource instances to this code block?

  4. Show all issues

    Should say "raised" instead of "thrown"

  5. Show all issues

    Too many spaces between sentences here.

  6. docs/manual/extending/extensions/models.rst (Diff revision 1)
     
     
     
     
     
     
     
     
     
    Show all issues

    Can we add a warning to never use --hint --execute?

  7. Show all issues

    "compiled down" is weird. How about just "compiled to CSS"?

  8. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        docs/manual/conf.py
    
    Ignored Files:
        docs/manual/extending/extensions/file-layout.rst
        docs/manual/extending/extensions/static-files.rst
        docs/manual/glossary.rst
        docs/manual/extending/extensions/distribution.rst
        docs/manual/extending/extensions/models.rst
        docs/manual/extending/extensions/configuration.rst
        docs/manual/extending/extensions/class.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        docs/manual/conf.py
    
    Ignored Files:
        docs/manual/extending/extensions/file-layout.rst
        docs/manual/extending/extensions/static-files.rst
        docs/manual/glossary.rst
        docs/manual/extending/extensions/distribution.rst
        docs/manual/extending/extensions/models.rst
        docs/manual/extending/extensions/configuration.rst
        docs/manual/extending/extensions/class.rst
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (5c6af82)