• 
      

    Fix issues with buffer sizes when doing TFS diffs.

    Review Request #8492 — Created Oct. 25, 2016 and submitted

    Information

    rb-tfs
    master
    66bf153...

    Reviewers

    In Java-land, especially when running on Windows, executed processes will halt
    if the buffer for their stdout or stderr streams fills up. This meant that
    diffs of sufficient size would hang forever. This change moves some things
    around such that we read both streams fully before waiting for the process to
    quit.

    Checked that the "diff" command still worked correctly and produced a diff.

    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          org/reviewboard/tfs/TFSDiffer.java
      
      
      
      Tool: Pyflakes
      Ignored Files:
          org/reviewboard/tfs/TFSDiffer.java
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (39f6aaa)