Allow RB integrations to filter on additional keyword arguments

Review Request #8475 - Created Oct. 18, 2016 and discarded

Barret Rennie
Review Board
release-3.0.x
reviewboard

The Djblets Integration definition of get_configs allows filtering by
arbitrary key value pairs. However, the Reivew Board version only allows
filtering by LocalSite, so this prevents filtering via integration ID
if only one configuration is required. This has been modified to allow
arbitrary key value pairs for filtering, which will be passed along to
the base class.



Review Bot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/integrations/base.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/integrations/base.py
    
    
  2. 
      
David Trowbridge
  1. Testing done?

  2. 
      
Christian Hammond
  1. Why do we want this? I intentionally removed the kwargs support so integrations wouldn't end up doing something silly. What's the use case for an integration trying to access a specific configuration?

  2. 
      
Barret Rennie
Review request changed

Status: Discarded

Loading...