Lower the delay for expanding diff context on hover

Review Request #8474 — Created Oct. 18, 2016 and submitted

Information

Review Board
release-2.5.x
4912d06...

Reviewers

Previously, the code that handled expanding the diff context
accidentally waited twice the timeout due to two calls to _.delay,
possibly from a refactoring that occurred to remove the $.hoverIntent
dependency. This has been removed and the delay has been lowered to
250ms (from 500ms) to make the UI feel much snappier. It used to take
over 1s to fully expand controls (500ms for each _.delay call plus
the length of jQuery's "slow" animation). It now takes just over half
that to fully expand them.

Hovered over fragments and saw the delay was reduced.


reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/diffFragmentQueueView.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/diffFragmentQueueView.js
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (7b176b7)
Loading...