• 
      

    Fix post-commit support for Bitbucket.

    Review Request #8460 — Created Oct. 12, 2016 and submitted

    Information

    Review Board
    release-2.5.x
    4ab1c7c...

    Reviewers

    The Bitbucket post-commit support was failing to generate a suitable
    diff for display. When fetching a commit, the base_commit_id field was
    being set to the ID of the commit, rather than the parent commit. This
    led to fetching the patched version of the files for the diff, rather
    than the source files.

    The Commit.base_commit_id field is deprecated and redundant these days.
    We instead want to use Commit.parent. This change updates everything to
    use that, and passes it through as the base commit ID for file
    fetches.

    Deprecation docs have also been updated accordingly.

    Unit tests pass.

    Manually tested post-commit on Bitbucket and GitLab (the two that both
    support post-commit and use base_commit_id.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/models/base_review_request_details.py
          reviewboard/scmtools/core.py
          reviewboard/hostingsvcs/bitbucket.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/models/base_review_request_details.py
          reviewboard/scmtools/core.py
          reviewboard/hostingsvcs/bitbucket.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (1c59ba1)