Summary

Clean up review task invocation a bit.

Review Request #8459 — Created Oct. 12, 2016 and submitted Oct. 26, 2016, 2:11 p.m.

Information

Owner

david

Repository

ReviewBot

Branch

master

Bugs

Depends On

Commit

1b25dba...

Reviewers

Groups

reviewbot

People

Description

The way that the review task was triggered was overly complicated, passing
through these relatively opaque "payload" and "request" dictionaries.
This change alters things to move a lot more of the info into their own
parameters.

Testing Done

Triggered Review Bot reviews by posting diffs.

Issues

Description	From	Last Updated
'logging' imported but unused	reviewbot	Oct. 12, 2016, 3:53 p.m.
'Profile' imported but unused	reviewbot	Oct. 12, 2016, 3:53 p.m.
Same here.	chipx86	Oct. 24, 2016, 3:54 p.m.
Mind specifying if this is the database ID or display ID?	chipx86	Oct. 24, 2016, 3:54 p.m.
Missing docstring.	chipx86	Oct. 24, 2016, 3:55 p.m.

Tool: PEP8 Style Checker
Processed Files:
    bot/reviewbot/tasks.py
    extension/reviewbotext/extension.py
    bot/reviewbot/processing/review.py
    extension/reviewbotext/handlers.py



Tool: Pyflakes
Processed Files:
    bot/reviewbot/tasks.py
    extension/reviewbotext/extension.py
    bot/reviewbot/processing/review.py
    extension/reviewbotext/handlers.py

extension/reviewbotext/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'logging' imported but unused
```
extension/reviewbotext/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'Profile' imported but unused
```

Commit:

9928bd759d6b7bef560a13575745af898b4f99f7

c9145ed429d4fe6398f69e837ee7c4aa095cc71a

Diff:

Revision 2 (+102 -135)

Show changes

	bot/reviewbot/tasks.py
	bot/reviewbot/processing/review.py
	extension/reviewbotext/extension.py
	extension/reviewbotext/handlers.py

Tool: Pyflakes
Processed Files:
    bot/reviewbot/tasks.py
    extension/reviewbotext/extension.py
    bot/reviewbot/processing/review.py
    extension/reviewbotext/handlers.py



Tool: PEP8 Style Checker
Processed Files:
    bot/reviewbot/tasks.py
    extension/reviewbotext/extension.py
    bot/reviewbot/processing/review.py
    extension/reviewbotext/handlers.py

bot/reviewbot/processing/review.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Same here.
```
bot/reviewbot/tasks.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Mind specifying if this is the database ID or display ID?
```
bot/reviewbot/tasks.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Missing docstring.
```
1. david Oct. 24, 2016, 3:56 p.m.
  This method is removed in /r/8442/

Commit:

c9145ed429d4fe6398f69e837ee7c4aa095cc71a

1b25dba552d00e73f358f7cd8c570a6d5d9f68d7

Diff:

Revision 3 (+104 -135)

Show changes

	bot/reviewbot/tasks.py
	bot/reviewbot/processing/review.py
	extension/reviewbotext/extension.py
	extension/reviewbotext/handlers.py

Tool: PEP8 Style Checker
Processed Files:
    bot/reviewbot/tasks.py
    extension/reviewbotext/extension.py
    bot/reviewbot/processing/review.py
    extension/reviewbotext/handlers.py



Tool: Pyflakes
Processed Files:
    bot/reviewbot/tasks.py
    extension/reviewbotext/extension.py
    bot/reviewbot/processing/review.py
    extension/reviewbotext/handlers.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (360fd55)

bot/reviewbot/tasks.py (Diff revision 2)

bot/reviewbot/tasks.py (Diff revision 2)