Summary

Modernize the ReviewGroupUserResource tests

Review Request #8457 — Created Oct. 12, 2016 and submitted Oct. 14, 2016, 2:43 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

~~8458~~

Commit

d310b4f...

Reviewers

Groups

reviewboard

People

Description

The tests for the ReviewGroupUserResource were not using the
webapi_test_template decorator and were therefore hardcoding the
resource URL into each test docstring. All such instances have been
updated to use the decorator.

In addition, the test for getting DELETE links on a local site has been
udpated to use get_local_site and test fixtures.

Testing Done

Ran unit tests. Saw they all contained the correct URLs.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/tests/test_review_group_user.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/tests/test_review_group_user.py

Depends On:: ~~8458 - Support users in multiple review groups in API responses~~

Ship it!

Ship It!

brennie Oct. 13, 2016, 4:13 p.m.

Im going to wait to land this because I want to update it once r/8458 is landed and merged so I don't have to do the same thing for the new test.

Status:: Completed
Change Summary:: Pushed to release-2.5.x (105db37)