Improve styling for the auth forms for errors, mobile, and number fields.

Review Request #8456 — Created Oct. 12, 2016 and submitted

Information

Review Board
release-2.5.x
b23ae9d...

Reviewers

This fixes up some small issues with styling on authentication forms
(login, register, etc.), particularly for RBCommons.

On mobile, the form is no longer slightly off-center. There was an
unwanted margin on the right that shouldn't have been there, and was
noticeable given the screen size.

Form errors were appearing off-center, instead of aligned with the
field. They're now lined up properly.

Number fields (which are used on RBCommons, but not Review Board) didn't
have the same styling as the other input fields. This adds the same
styling for those fields.

<button> elements were also failing to be styled like other buttons.
This is also fixed.

Tested the mobile and desktop versions of these styles on Review Board
and RBCommons.

Description From Last Updated

Screenshots?

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/css/common.less
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/css/common.less
    
    
  2. 
      
chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/css/common.less
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/css/common.less
    
    
  2. 
      
brennie
  1. 
      
  2. Show all issues

    Screenshots?

    1. They really apply to RBCommons (which I have a whole bunch of screenshots for on the corresponding change).

  3. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (bd3c48d)