Improve styling for the auth forms for errors, mobile, and number fields.
Review Request #8456 — Created Oct. 12, 2016 and submitted
This fixes up some small issues with styling on authentication forms (login, register, etc.), particularly for RBCommons. On mobile, the form is no longer slightly off-center. There was an unwanted margin on the right that shouldn't have been there, and was noticeable given the screen size. Form errors were appearing off-center, instead of aligned with the field. They're now lined up properly. Number fields (which are used on RBCommons, but not Review Board) didn't have the same styling as the other input fields. This adds the same styling for those fields. <button> elements were also failing to be styled like other buttons. This is also fixed.
Tested the mobile and desktop versions of these styles on Review Board
and RBCommons.
| Description | From | Last Updated |
|---|---|---|
|
Screenshots? |
 brennie
|
- Change Summary:
-
Fixed styling for
<button>on auth forms. - Description:
-
This fixes up some small issues with styling on authentication forms
(login, register, etc.), particularly for RBCommons. On mobile, the form is no longer slightly off-center. There was an
unwanted margin on the right that shouldn't have been there, and was noticeable given the screen size. Form errors were appearing off-center, instead of aligned with the
field. They're now lined up properly. Number fields (which are used on RBCommons, but not Review Board) didn't
have the same styling as the other input fields. This adds the same styling for those fields. + + <button> elements were also failing to be styled like other buttons.
+ This is also fixed. - Commit:
-
edab4389ed8f0b778aafd80409b778ffa038c021b23ae9d0a37121617beee394b435a26b1c10aaed
- Diff:
-
Revision 2 (+7 -1)
Tool: Pyflakes Ignored Files: reviewboard/static/rb/css/common.less Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/css/common.less