Make password encryption correctly handle non-ASCII strings.
Review Request #8453 — Created Oct. 11, 2016 and submitted
It's rare for people to use non-ASCII passwords, but it does happen in some
cases. Most of our code deals with this correctly, but the password encryption
and decryption would fail. This change adds the necessary encode/decode steps.
If someone is using non-ASCII passwords with an encoding other than utf-8
they're out of luck.
- Connected an SVN repository using a password containing unicode. Before this
change, saving the form would fail. After, it works. I also checked the
contents of the form field after saving it to verify that we were pulling the
password back out correctly. I was also able to create a post-commit review
request using this repository. - Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Are there exceptions we might want to check for and log here and below? |
 chipx86
|
Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/models.py Tool: Pyflakes Processed Files: reviewboard/scmtools/models.py