Status Updates part 9: centralize code to expand boxes to initial hash.
Review Request #8446 — Created Sept. 28, 2016 and submitted
When loading a page that has something like "#review20" in the window location,
we had some code to expand the review box that matched. The addition of reviews
within the initial status reports and change description boxes duplicated this
code two additional times.This change moves that responsibility into the
ReviewRequestPageView. This
now just generically searches each box for a matching selector, expanding if it
finds it. This means that it's much more general, and linking to individual
comments will also expand their container.
Checked that the matching boxes were correctly expanded when loading the page
with a variety of different hash values.
-
-
I don't really like trusting user input for a selector like this. While I don't know of any attack vectors (jQuery at least will block HTML tags in a
$(...)), I feel we should probably sanity-check what we get here. We can do this pretty effectively with:box.render(); const selector = window.location.hash.match(/^#[A-Za-z0-9_\.-]+/); if (selector && box.$(selector[0]).length > 0) { ... } -
- Change Summary:
-
Made requested changes.
- Commit:
-
ed7c24db191ea3f74151c766fc1a22c677e18a2de3620a0f233147be161b1dc70fd18f2ff8de242d
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/changeBoxView.es6.js reviewboard/static/rb/js/views/reviewBoxView.es6.js reviewboard/static/rb/js/views/initialStatusUpdatesBoxView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/changeBoxView.es6.js reviewboard/static/rb/js/views/reviewBoxView.es6.js reviewboard/static/rb/js/views/initialStatusUpdatesBoxView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/changeBoxView.es6.js reviewboard/static/rb/js/views/reviewBoxView.es6.js reviewboard/static/rb/js/views/initialStatusUpdatesBoxView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/changeBoxView.es6.js reviewboard/static/rb/js/views/reviewBoxView.es6.js reviewboard/static/rb/js/views/initialStatusUpdatesBoxView.es6.js reviewboard/static/rb/js/pages/views/reviewRequestPageView.es6.js