This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-0.10.x (6d3826e)

Summary

Adding tests for utils.dates

Review Request #8439 — Created Sept. 25, 2016 and submitted 8 years, 6 months ago

Information

Owner

larmiej*

Repository

Djblets

Branch

master

Bugs

Depends On

Commit

71eddd6...

Reviewers

Groups

djblets, students

People

Description*

Djblets has some utility functions for working with dates/timestamps

that did not have any unit tests for them.

The cursor of some text fields in an edit state displayed the standard

Added new DatesTests class to djblets/util/tests.py that covers

testing for:
Calling http_date():

- With a datetime object.

- With a string representing a date.

- With an integer representing a Unix timestamp (seconds since the 

epoch).
Calling get_latest_timestamp():

- Without any timestamps in the list (result should be None)

- With a list of timestamps of different values in a jumbled, 

unsorted order, checking that the latest gets returned.
Calling get_tz_aware_utcnow() and checking that the resulting 

datetime's timezone is UTC

Testing Done

Added tests

Issues

Description	From	Last Updated
'time' imported but unused	reviewbot	8 years, 7 months ago
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	8 years, 7 months ago
djblets.util comes before djblets.util.foo	brennie	8 years, 7 months ago
http_date	brennie	8 years, 7 months ago
http_date	brennie	8 years, 7 months ago
http_date	brennie	8 years, 7 months ago
UTC is capitalized.	brennie	8 years, 7 months ago
Undo this.	brennie	8 years, 6 months ago
Same here.	brennie	8 years, 6 months ago
Same here.	brennie	8 years, 6 months ago
Use the function name in the docstring.	brennie	8 years, 6 months ago
There are no open issues

Tool: Pyflakes
Processed Files:
    djblets/util/tests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/tests.py

djblets/util/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'time' imported but unused
```
djblets/util/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```

Commit:

42dc74859bd372227cf21829c4f3b4673549e2d5

1d8b6169a9cd0c8c4926e450a601f7dc597c4a60

Diff:

Revision 2 (+22 -1)

Show changes

djblets/util/tests.py

Tool: Pyflakes
Processed Files:
    djblets/util/tests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/tests.py

Summary:: adding tests for utils.dates
WIP: adding tests for utils.dates

djblets/util/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
djblets.util comes before djblets.util.foo
```

Change Summary:

Added unit tests for dates.py

Summary:

WIP: adding tests for utils.dates

Adding tests for utils.dates

Commit:

1d8b6169a9cd0c8c4926e450a601f7dc597c4a60

40f34d95e2f5313901d878152575ce50f81db7af

Diff:

Revision 3 (+45 -1)

Show changes

djblets/util/tests.py

djblets/util/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
http_date
```
djblets/util/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
http_date
```
djblets/util/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
http_date
```
djblets/util/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
UTC is capitalized.
```

Tool: Pyflakes
Processed Files:
    djblets/util/tests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/tests.py

Change Summary:

Fixed "http date" issues with function doc strings

Commit:

40f34d95e2f5313901d878152575ce50f81db7af

e372712ec4518183707994fa39aa5d438927ad35

Diff:

Revision 4 (+44 -1)

Show changes

djblets/util/tests.py

Tool: Pyflakes
Processed Files:
    djblets/util/tests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/tests.py

Ship it!

djblets/util/tests.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Undo this.
```
djblets/util/tests.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Same here.
```
djblets/util/tests.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Same here.
```
djblets/util/tests.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Use the function name in the docstring.
```

Commit:

e372712ec4518183707994fa39aa5d438927ad35

3c2e8c9c242034468157415adcf98552396dac7d

Diff:

Revision 5 (+44)

Show changes

djblets/util/tests.py

Tool: Pyflakes
Processed Files:
    djblets/util/tests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/tests.py

Change Summary:

fixing test function doc strings

Commit:

3c2e8c9c242034468157415adcf98552396dac7d

71eddd61507d105c8d46cf4a5b4a7d4a31dcf07b

Diff:

Revision 6 (+44)

Show changes

djblets/util/tests.py

Tool: PEP8 Style Checker
Processed Files:
    djblets/util/tests.py



Tool: Pyflakes
Processed Files:
    djblets/util/tests.py

Status:: Completed
Change Summary:: Pushed to release-0.10.x (6d3826e)

djblets/util/tests.py (Diff revision 1)

djblets/util/tests.py (Diff revision 1)

djblets/util/tests.py (Diff revision 2)

djblets/util/tests.py (Diff revision 3)