• 
      

    Add tests for using GroupForm and DefaultReviewerForm with positional args.

    Review Request #8431 — Created Sept. 24, 2016 and submitted

    Information

    Review Board
    release-2.5.x
    f287751...

    Reviewers

    The regression in the GroupForm was caused by the fact that the admin site
    passes in the data to bind to the form as a positional argument rather than a
    keyword argument. This meant that the data was being stuck into the
    local_site_name argument rather than getting passed through to the base
    class.

    This change adds some unit tests to make sure we don't cause a similar problem
    in the future. I also cleaned up some of the docstrings for adjacent tests to
    match our conventions.

    Ran the new tests. Before the fix to the forms, the new tests fail. After, they
    run successfully.

    Description From Last Updated

    """ on the next line.

    chipx86chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/tests/test_forms.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/tests/test_forms.py
      
      
    2. 
        
    chipx86
    1. 
        
    2. reviewboard/reviews/tests/test_forms.py (Diff revision 1)
       
       
      Show all issues

      """ on the next line.

    3. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (c7a17e8)