Clean up some old cruft from SCMTools.

Review Request #8428 — Created Sept. 21, 2016 and submitted

Information

Review Board
release-3.0.x
20461b0...

Reviewers

This removes an old method (get_fields()), which is no longer used in
any way. This used to be used to influence the New Review Request
dialog, but that was rewritten long ago.

It also replaces get_diffs_use_absolute_diffs() with a
diffs_use_absolute_diffs attribute (with defaults to being a property
that supports the old method for backward-compatibility).

Unit tests pass.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/scmtools/bzr.py
        reviewboard/scmtools/mtn.py
        reviewboard/scmtools/tests/test_cvs.py
        reviewboard/scmtools/hg.py
        reviewboard/scmtools/git.py
        reviewboard/scmtools/clearcase.py
        reviewboard/scmtools/localfile.py
        reviewboard/scmtools/core.py
        reviewboard/scmtools/perforce.py
        reviewboard/scmtools/cvs.py
        reviewboard/webapi/resources/validate_diff.py
        reviewboard/scmtools/tests/test_hg.py
        reviewboard/scmtools/plastic.py
        reviewboard/scmtools/tests/test_svn.py
        reviewboard/diffviewer/forms.py
        reviewboard/testing/scmtool.py
        reviewboard/scmtools/svn/__init__.py
    
    Ignored Files:
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/views.py
        reviewboard/scmtools/bzr.py
        reviewboard/scmtools/mtn.py
        reviewboard/scmtools/tests/test_cvs.py
        reviewboard/scmtools/hg.py
        reviewboard/scmtools/git.py
        reviewboard/scmtools/clearcase.py
        reviewboard/scmtools/localfile.py
        reviewboard/scmtools/core.py
        reviewboard/scmtools/perforce.py
        reviewboard/scmtools/cvs.py
        reviewboard/webapi/resources/validate_diff.py
        reviewboard/scmtools/tests/test_hg.py
        reviewboard/scmtools/plastic.py
        reviewboard/scmtools/tests/test_svn.py
        reviewboard/diffviewer/forms.py
        reviewboard/testing/scmtool.py
        reviewboard/scmtools/svn/__init__.py
    
    Ignored Files:
        reviewboard/templates/reviews/reviewable_page_data.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (347e0ff)