Fix the attributes of the resolution menu
Review Request #8427 — Created Sept. 21, 2016 and submitted — Latest diff uploaded
During review, the code for generating the resolution menu changed from
using afor [a, b] of scalingFactors.items()
loop to a
scalingFactors.foreach((a, b))
call. However, the parameters for the
callback toMap.prototype.foreach
are backwards compared to what is
returned byMap.prototype.items
. This lead to the resolution menu
having its text anddata-image-scale
attribute swapped. This patch
addresses that issue.
- Verified that the text and data attributes were generated correctly.
- Verified that the menu switched the resolution.