• 
      

    Fix the attributes of the resolution menu

    Review Request #8427 — Created Sept. 21, 2016 and submitted

    Information

    Review Board
    release-3.0.x
    b404dd3...

    Reviewers

    During review, the code for generating the resolution menu changed from
    using a for [a, b] of scalingFactors.items() loop to a
    scalingFactors.foreach((a, b)) call. However, the parameters for the
    callback to Map.prototype.foreach are backwards compared to what is
    returned by Map.prototype.items. This lead to the resolution menu
    having its text and data-image-scale attribute swapped. This patch
    addresses that issue.

    • Verified that the text and data attributes were generated correctly.
    • Verified that the menu switched the resolution.
    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/views/imageReviewableView.es6.js
      
      
      
      Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/views/imageReviewableView.es6.js
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (96332a9)