Fix the attributes of the resolution menu
Review Request #8427 — Created Sept. 21, 2016 and submitted
During review, the code for generating the resolution menu changed from
using afor [a, b] of scalingFactors.items()loop to a
scalingFactors.foreach((a, b))call. However, the parameters for the
callback toMap.prototype.foreachare backwards compared to what is
returned byMap.prototype.items. This lead to the resolution menu
having its text anddata-image-scaleattribute swapped. This patch
addresses that issue.
- Verified that the text and data attributes were generated correctly.
- Verified that the menu switched the resolution.
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/imageReviewableView.es6.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/imageReviewableView.es6.js