• 
      

    Revert the change to combine from_email and extra_headers['From'].

    Review Request #8413 — Created Sept. 19, 2016 and submitted

    Information

    Djblets
    release-0.9.x
    1aa51ee...

    Reviewers

    In an earlier change (2c4310d), I removed the separation of the
    from_email attribute and custom 'From' header, as it didn't appear
    necessary for the e-mail behavior we had. It turns out, however, that
    this change was important after-all. Deep in the bowels of Django's
    e-mail code, these two values are treated differently. This part of the
    change has been reverted, with a new comment added explaining the
    difference.

    Updated unit tests for the new expected values. They pass.

    david
    1. Ship It!
    2. 
        
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          djblets/mail/tests.py
          djblets/mail/message.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          djblets/mail/tests.py
          djblets/mail/message.py
      
      
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.9.x (ecdbb7d)