Summary

Simplify context for issue summary table.

Review Request #8395 — Created Sept. 12, 2016 and submitted Sept. 13, 2016, 10:17 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

8875dbf...

Reviewers

Groups

reviewboard

People

Description

The issue summary table was looping over all the entries, checking if they were
reviews, then looping over all the comments therein, checking if there's an
open issue, and finally rendering stuff. This was overly complex, and will get
even more so once entries other than review boxes can contain issues.

Since we're already processing all the comments in the ReviewRequestPageData
object, we might as well aggregate all of the ones with open issues into a
list, and just use that.

Testing Done

Verified that the issue summary table displayed the same as before.

Description:: The issue summary table was looping over all the entries, checking if they were
reviews, then looping over all the comments therein, checking if there's an
open issue, and finally rendering stuff. This was overly complex, and will get
even more so once entries other than review boxes can contain issues.

Since we're already processing all the comments in the ReviewRequestPageData
object, we might as well aggregate all of the ones with open issues into a
list, and just use that.
-
-
Testing done:
- Verified that the issue summary table displayed the same as before.
Testing Done:: +
Verified that the issue summary table displayed the same as before.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (dd2d515)

		The issue summary table was looping over all the entries, checking if they were
		reviews, then looping over all the comments therein, checking if there's an
		open issue, and finally rendering stuff. This was overly complex, and will get
		even more so once entries other than review boxes can contain issues.

		Since we're already processing all the comments in the `ReviewRequestPageData`
		object, we might as well aggregate all of the ones with open issues into a
		list, and just use that.
-
-		Testing done:
-		Verified that the issue summary table displayed the same as before.