Auto scale large images according to size
Review Request #8392 — Created Sept. 8, 2016 and submitted
Previously, we scaled images that contained
@2xor@3xin their
filenames. For images that do not contain those hints, we now scale them
to the highest scaling factor less than or equal to 1 that allows the
most of the image to be shown.
Tested with a very large image and saw that it was scaled correctly in
image diff and single image mode.
| Description | From | Last Updated |
|---|---|---|
|
"Subclasses" |
 chipx86
|
|
|
I know this was already here, but .includes isn't available in all browsers, and Babel doesn't do anything for it. … |
chipx86
|
|
|
Array.from isn't available in all browsers. |
chipx86
|
|
|
Can you put the comparison in parens? It'll help with making it clearer, given the => syntax. (Otherwise it almost … |
chipx86
|
|
|
These could be moved inline into the return statement with no loss of clarity. |
 david
|
|
|
Same here. |
david
|
-
-
-
I know this was already here, but
.includesisn't available in all browsers, and Babel doesn't do anything for it. We should use.indexOfinstead. -
-
Can you put the comparison in parens? It'll help with making it clearer, given the
=>syntax. (Otherwise it almost looks like Python's ability to do things like3 >= 2 <= 5.)
- Change Summary:
-
Addressed Christian's issues
-
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/imageReviewableView.es6.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/imageReviewableView.es6.js
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/imageReviewableView.es6.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/imageReviewableView.es6.js
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/imageReviewableView.es6.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/imageReviewableView.es6.js