• 
      

    Fix onclick bug triggering invalid diff modes

    Review Request #8389 — Created Sept. 8, 2016 and submitted

    Information

    Review Board
    release-3.0.x

    Reviewers

    Previously, it was possible to click between two image diff modes and
    invoke the image mode changed function (due to padding). Now, the class
    is directly on the <a> tag instead of the surrounding <li> tag,
    which prevents this issue. This was causing an error (due to a missing
    data-mode attribute on the <li> (the event target) that caused the
    image review UI to stop functioning.

    Clicked between two image modes. The image review UI no longer breaks.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/views/imageReviewableView.es6.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/views/imageReviewableView.es6.js
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    brennie
    brennie
    brennie
    Review request changed
    Change Summary:

    Pushed to release-3.0.x (ba12ec8)

    Branch:
    release-2.5.x
    release-3.0.x