• 
      

    Fix some issues with screenshot commenting.

    Review Request #8385 — Created Sept. 5, 2016 and submitted

    Information

    Review Board
    release-3.0.x
    986b82b...

    Reviewers

    This fixes a couple bugs that have snuck in when commenting on legacy
    screenshots. The first one was that the screenshot comment model doesn't define
    canUpdateBounds, which was causing an error trying to call it. While fixing
    that I fixed up some documentation on the matching version for image file
    attachments. The second bug was that the screenshot model doesn't have a
    filename attribute, which was causing a similar error when trying to decide
    the default zoom level to use.

    Was able to comment on a screenshot without errors. Verified, to my surprise,
    that the new zoom feature worked without issues.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/models/screenshotCommentBlockModel.js
          reviewboard/static/rb/js/views/imageReviewableView.es6.js
          reviewboard/static/rb/js/models/regionCommentBlockModel.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/models/screenshotCommentBlockModel.js
          reviewboard/static/rb/js/views/imageReviewableView.es6.js
          reviewboard/static/rb/js/models/regionCommentBlockModel.js
      
      
    2. 
        
    chipx86
    1. Looks like part of this is applicable to 2.5.x. Can we backport that?

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (8a39b87)