• 
      

    Fix starring review requests on the dashboard after adding the column.

    Review Request #8383 — Created Sept. 5, 2016 and submitted

    Information

    Review Board
    release-2.5.x
    204141c...

    Reviewers

    Clicking the star icons for a review request in the dashboard
    immediately after adding the Star column ended up taking the user to the
    review request page, instead of toggling the star state. This happened
    because the StarManager, which was responsible for handling events on
    these stars, was listening for events on the old datagrid element after
    the page updated, rather than listening on the new element.

    We now rebuild the StarManager instance after the datagrid reloads,
    allowing it to recollect the star elements and handle events.

    Started off with a dashboard without the Star column. Added the column
    and tried starring a review request. Saw that it starred, rather than
    taking the user to the review request page.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/pages/views/datagridPageView.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/pages/views/datagridPageView.js
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (fc9ddc6)