Summary

Change the Ship It column to show the number of Ship It reviews.

Review Request #838 — Created April 27, 2009 and submitted

Information

Owner

chipx86

Repository

Review Board SVN (deprecated)

Branch

trunk

Bugs

919

Depends On

Reviewers

Groups

reviewboard

People

Description

Change the Ship It column to show the number of Ship It reviews.

This change adds the number of reviews marked Ship It to the existing
Ship It column. Instead of showing just a pre-made icon, we now have a
little stylized box with a checkmark and the number beside it.

This ends up looking pretty decent on browsers that suppor rounded
corners. On IE, this will just be a box, but that's not too horrible.

Testing Done

Tested with various reviews with different numbers of reviews marked Ship It. Saw what I expected.

Also made sure sorting by review count worked.

Screenshots

Ship It Counts

Change Summary:: Added a screenshot showing off the new column changes.

What happens with zoomed fonts or > 9 ship-its?

chipx86 April 27, 2009, 3:47 a.m.

It scales fine. The issue is the checkmark, as it's a PNG, but that's no different than any other image on the site. I look forward to the day when we can use SVGs everywhere.