Fix the new superuser_required decorator when not logged in.

Review Request #8379 — Created Sept. 3, 2016 and submitted

Information

Review Board
release-2.5.x
ca9e6e6...

Reviewers

The @superuser_required decorator was passing a dictionary of keyword
arguments, instead of the keyword arguments themselves, to the login()
method. This broke login(), which saw that dictionary as the
template_name argument.

This fixes the code to pass those in as keyword arguments, and fixes the
name of one of the arguments, allowing the view to show a login page
instead of a 500.

Tested visiting as a logged-out user. Saw a login form. Logged in using
it and was taken to the settings page.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/admin/decorators.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/admin/decorators.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (6e2b802)