• 
      

    Add release notes for Review Board 2.5.7.

    Review Request #8362 — Created Aug. 29, 2016 and submitted

    Information

    Review Board
    release-2.5.x
    67de132...

    Reviewers

    This covers all the improvements made since 2.5.6.1. Some of the
    highlights include:
    
    * New user selector
    * E-mail improvements
    * Settings access controls for staff members
    * Fixes for custom fields and rich text
    * Fixes for WebHooks
    * Fixes for Local Sites
    * Fixes CVS, Bitbucket, and GitLab

    Built the docs. Sphinx didn't complain about any references, syntax,
    or links.

    Manually checked the links and references.

    Ran spell check.

    Description From Last Updated

    I want to get https://reviews.reviewboard.org/r/8458/ in there

    brenniebrennie

    Should be "there are" rather than "there's". You can also get rid of "in it"

    daviddavid

    typo: "reodering"

    daviddavid

    Drop "an".

    gmyersgmyers

    This still reads weird due to "in it", which I think is being hidden by the line break. Read these …

    daviddavid
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          docs/releasenotes/conf.py
      
      Ignored Files:
          docs/releasenotes/index.rst
          docs/releasenotes/2.5.7.rst
          AUTHORS
      
      
      
      Tool: Pyflakes
      Processed Files:
          docs/releasenotes/conf.py
      
      Ignored Files:
          docs/releasenotes/index.rst
          docs/releasenotes/2.5.7.rst
          AUTHORS
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          docs/releasenotes/conf.py
      
      Ignored Files:
          docs/releasenotes/index.rst
          docs/releasenotes/2.5.7.rst
          AUTHORS
      
      
      
      Tool: Pyflakes
      Processed Files:
          docs/releasenotes/conf.py
      
      Ignored Files:
          docs/releasenotes/index.rst
          docs/releasenotes/2.5.7.rst
          AUTHORS
      
      
    2. 
        
    david
    1. 
        
    2. docs/releasenotes/2.5.7.rst (Diff revisions 1 - 2)
       
       
      Show all issues

      Should be "there are" rather than "there's". You can also get rid of "in it"

    3. docs/releasenotes/2.5.7.rst (Diff revisions 1 - 2)
       
       
      Show all issues

      typo: "reodering"

      1. I like mine better. :D

    4. 
        
    chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          docs/releasenotes/conf.py
      
      Ignored Files:
          docs/releasenotes/index.rst
          docs/releasenotes/2.5.7.rst
          AUTHORS
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          docs/releasenotes/conf.py
      
      Ignored Files:
          docs/releasenotes/index.rst
          docs/releasenotes/2.5.7.rst
          AUTHORS
      
      
    2. 
        
    david
    1. 
        
    2. docs/releasenotes/2.5.7.rst (Diff revisions 2 - 3)
       
       
       
      Show all issues

      This still reads weird due to "in it", which I think is being hidden by the line break. Read these aloud and compare:

      Attempting to close the comment dialog while there are unsaved changes in it now prompts for confirmation.

      to:

      Attempting to close the comment dialog while there are unsaved changes now prompts for confirmation.

    3. 
        
    gmyers
    1. 
        
    2. docs/releasenotes/2.5.7.rst (Diff revisions 1 - 3)
       
       
      "deleted in one revision, then deleted" is confusing to me.  Do you mean "added in one revision..."?
      1. Yeah, that was confusing. I've updated this to hopefully better describe the scenario. (It's a confusing and tricky corner case we hit.)

    3. docs/releasenotes/2.5.7.rst (Diff revisions 1 - 3)
       
       
      Show all issues
      Drop "an".
    4. docs/releasenotes/2.5.7.rst (Diff revision 3)
       
       
       
       
       
      I suspect "Patch..." should be spaced over to maintain alignment.
      1. Yep, fixed locally but I didn't update. Thanks!

    5. 
        
    chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          docs/releasenotes/conf.py
      
      Ignored Files:
          docs/releasenotes/index.rst
          docs/releasenotes/2.5.7.rst
          AUTHORS
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          docs/releasenotes/conf.py
      
      Ignored Files:
          docs/releasenotes/index.rst
          docs/releasenotes/2.5.7.rst
          AUTHORS
      
      
    2. 
        
    gmyers
    1. Ship It!
    2. 
        
    brennie
    1. Can we sneak the

    2. Show all issues

      I want to get https://reviews.reviewboard.org/r/8458/ in there

      1. And https://reviews.reviewboard.org/r/8457/

      2. These have landed, so once theyre in the docs LGTM!

      3. This won't be the final version of the release notes. There will be another update before release. Probably later tonight/tomorrow.

    3. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          docs/releasenotes/conf.py
      
      Ignored Files:
          docs/releasenotes/index.rst
          docs/releasenotes/2.5.7.rst
          AUTHORS
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          docs/releasenotes/conf.py
      
      Ignored Files:
          docs/releasenotes/index.rst
          docs/releasenotes/2.5.7.rst
          AUTHORS
      
      
    2. 
        
    chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          docs/releasenotes/conf.py
      
      Ignored Files:
          docs/releasenotes/index.rst
          docs/releasenotes/2.5.7.rst
          AUTHORS
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          docs/releasenotes/conf.py
      
      Ignored Files:
          docs/releasenotes/index.rst
          docs/releasenotes/2.5.7.rst
          AUTHORS
      
      
    2. 
        
    chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          docs/releasenotes/conf.py
      
      Ignored Files:
          docs/releasenotes/index.rst
          reviewboard/templates/diffviewer/diff_fragment_side_by_side.html
          docs/releasenotes/2.5.7.rst
          AUTHORS
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          docs/releasenotes/conf.py
      
      Ignored Files:
          docs/releasenotes/index.rst
          reviewboard/templates/diffviewer/diff_fragment_side_by_side.html
          docs/releasenotes/2.5.7.rst
          AUTHORS
      
      
    2. 
        
    brennie
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (0fc4600)