Clean up much of the old code in the reviews unit tests.

Review Request #8361 — Created Aug. 29, 2016 and submitted — Latest diff uploaded

Information

Review Board
release-3.0.x
cdc3fc3...

Reviewers

The reviews unit tests are some of the oldest in the codebase, and
predated a lot of our modern best practices. This change goes through
and applies a bunch of changes, such as:

* Docstrings for classes
* Single quotes instead of double quotes
* Spacing between class docstring and members
* Private functions below public functions
* Removed period at the end of the sentence for unit test docstrings
* Unit test docstrings that mention the class/function
* Usage of "with" when using assertRaises

The review request issues test suite also moved into
test_review_request.py.

Unit tests pass.

reviewboard/reviews/tests/test_counters.py
reviewboard/reviews/tests/test_default_groups.py
reviewboard/reviews/tests/test_default_reviewer.py
reviewboard/reviews/tests/test_fields.py
reviewboard/reviews/tests/test_forms.py
reviewboard/reviews/tests/test_review.py
reviewboard/reviews/tests/test_review_request.py
reviewboard/reviews/tests/test_review_request_draft.py
reviewboard/reviews/tests/test_review_request_manager.py
reviewboard/reviews/tests/test_template_tags.py
reviewboard/reviews/tests/test_views.py
Loading...