Clean up much of the old code in the reviews unit tests.

Review Request #8361 — Created Aug. 29, 2016 and submitted

Information

Review Board
release-3.0.x
cdc3fc3...

Reviewers

The reviews unit tests are some of the oldest in the codebase, and
predated a lot of our modern best practices. This change goes through
and applies a bunch of changes, such as:

* Docstrings for classes
* Single quotes instead of double quotes
* Spacing between class docstring and members
* Private functions below public functions
* Removed period at the end of the sentence for unit test docstrings
* Unit test docstrings that mention the class/function
* Usage of "with" when using assertRaises

The review request issues test suite also moved into
test_review_request.py.

Unit tests pass.

Description From Last Updated

models not modeels.

gmyersgmyers
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/tests/test_review_request_manager.py
        reviewboard/reviews/tests/test_review_request_draft.py
        reviewboard/reviews/tests/test_default_groups.py
        reviewboard/reviews/tests/test_review.py
        reviewboard/reviews/tests/test_review_request.py
        reviewboard/reviews/tests/test_forms.py
        reviewboard/reviews/tests/test_fields.py
        reviewboard/reviews/tests/test_template_tags.py
        reviewboard/reviews/tests/test_counters.py
        reviewboard/reviews/tests/test_views.py
        reviewboard/reviews/tests/test_default_reviewer.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/tests/test_review_request_manager.py
        reviewboard/reviews/tests/test_review_request_draft.py
        reviewboard/reviews/tests/test_default_groups.py
        reviewboard/reviews/tests/test_review.py
        reviewboard/reviews/tests/test_review_request.py
        reviewboard/reviews/tests/test_forms.py
        reviewboard/reviews/tests/test_fields.py
        reviewboard/reviews/tests/test_template_tags.py
        reviewboard/reviews/tests/test_counters.py
        reviewboard/reviews/tests/test_views.py
        reviewboard/reviews/tests/test_default_reviewer.py
    
    
  2. 
      
gmyers
  1. 
      
  2. Show all issues
    models not modeels.
  3. 
      
chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/tests/test_review_request_manager.py
        reviewboard/reviews/tests/test_review_request_draft.py
        reviewboard/reviews/tests/test_default_groups.py
        reviewboard/reviews/tests/test_review.py
        reviewboard/reviews/tests/test_review_request.py
        reviewboard/reviews/tests/test_forms.py
        reviewboard/reviews/tests/test_fields.py
        reviewboard/reviews/tests/test_template_tags.py
        reviewboard/reviews/tests/test_counters.py
        reviewboard/reviews/tests/test_views.py
        reviewboard/reviews/tests/test_default_reviewer.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/tests/test_review_request_manager.py
        reviewboard/reviews/tests/test_review_request_draft.py
        reviewboard/reviews/tests/test_default_groups.py
        reviewboard/reviews/tests/test_review.py
        reviewboard/reviews/tests/test_review_request.py
        reviewboard/reviews/tests/test_forms.py
        reviewboard/reviews/tests/test_fields.py
        reviewboard/reviews/tests/test_template_tags.py
        reviewboard/reviews/tests/test_counters.py
        reviewboard/reviews/tests/test_views.py
        reviewboard/reviews/tests/test_default_reviewer.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (d3f2f87)