• 
      

    Don't always show the vertical scrollbar on the user selector.

    Review Request #8355 — Created Aug. 26, 2016 and submitted

    Information

    Review Board
    release-2.5.x
    e671bda...

    Reviewers

    The new user selector was always showing space for a vertical scrollbar,
    which looked bad on any OS that shows scrollbars inline. This was due to
    an overflow-y: scroll rule.

    This change makes the scrollbar only appear when necessary, using auto
    instead. If there isn't enough room for the list, the scrollbar will
    kick in, but otherwise it will be hidden.

    Looked at the user selector and saw that the contents of the list were
    flush with the sides. No scrollbar space was being reserved.

    Forced the height of the list to be too small for the contents, and saw
    the scrollbar appear.

    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/css/ui/related-object-selector.less
      
      
      
      Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/css/ui/related-object-selector.less
      
      
    2. 
        
    brennie
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (4cbe22f)