This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-3.0.x (958dd4b)

Summary

Add support for Splat as a bug tracker

Review Request #8343 — Created Aug. 23, 2016 and submitted 8 years, 10 months ago

Information

Owner

brennie*

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

3239bfc...

Reviewers

Groups

reviewboard

People

Description*

The patch adds support for using Splat as a bug tracker for a
repository. As Splat is a SaaS, only the https://hellosplat.com instance
is supported.

Testing Done

Added Splat as a bug tracker and saw the correct information in the bug
infobox. The bug URL view redirected to the correct place.

Files

Markdown bug text

HTML bug text

Issues

Description	From	Last Updated
No need for "the."	chipx86	8 years, 10 months ago
Can you use forms.SlugField instead of CharField with a validator?	chipx86	8 years, 10 months ago
Mind fleshing this out to say a little more about Splat, including the URL and that it's Beanbag's bug tracker?	chipx86	8 years, 10 months ago
We'll get more accurate results using reviewboard.reviews.markdown_utils.render_markdown(). The extensions and settings used here are consistent between Review Board and Splat.	chipx86	8 years, 10 months ago
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	8 years, 10 months ago
There are no open issues

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/splat.py
    setup.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/splat.py
    setup.py

Markdown bug text (Revision 1)

Oof, we need to seriously give the styling on this some love.

reviewboard/hostingsvcs/splat.py (Diff revision 1)
The issue has been resolved. Show all issues
```
No need for "the."
```
1. brennie 8 years, 10 months ago
  I don't see any grammatical issues at all.
reviewboard/hostingsvcs/splat.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you use forms.SlugField instead of CharField with a validator?
```

reviewboard/hostingsvcs/splat.py (Diff revision 1)

The issue has been resolved. Show all issues

Mind fleshing this out to say a little more about Splat, including the URL and that it's Beanbag's bug tracker?

reviewboard/hostingsvcs/splat.py (Diff revision 1)

The issue has been resolved. Show all issues

We'll get more accurate results using reviewboard.reviews.markdown_utils.render_markdown(). The extensions and settings used here are consistent between Review Board and Splat.

Change Summary:

Addressed Christian's issues

Commit:

4c8355af922884246175ac047706dca14c9af67e

8f64594f5ec2e82a8ae52d6a23e1fa7482a22650

Diff:

Revision 2 (+83)

Show changes

	setup.py
	reviewboard/hostingsvcs/splat.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/splat.py
    setup.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/splat.py
    setup.py

Change Summary:

Actually add files to git.

Commit:

8f64594f5ec2e82a8ae52d6a23e1fa7482a22650

3239bfcd5aa9e7997e61517cedb346c03768ea44

Diff:

Revision 3 (+85)

Show changes

	setup.py
	reviewboard/hostingsvcs/splat.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/splat.py
    setup.py



Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/splat.py
    setup.py

reviewboard/hostingsvcs/splat.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Addressed Christian's issues

You're not my psychiatrist!

Ship it!

```
Happy after Review Bot's comment.
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (958dd4b)