Add support for Splat as a bug tracker

Review Request #8343 — Created Aug. 23, 2016 and submitted

Information

Review Board
release-3.0.x
3239bfc...

Reviewers

The patch adds support for using Splat as a bug tracker for a
repository. As Splat is a SaaS, only the https://hellosplat.com instance
is supported.

Added Splat as a bug tracker and saw the correct information in the bug
infobox. The bug URL view redirected to the correct place.


Description From Last Updated

No need for "the."

chipx86chipx86

Can you use forms.SlugField instead of CharField with a validator?

chipx86chipx86

Mind fleshing this out to say a little more about Splat, including the URL and that it's Beanbag's bug tracker?

chipx86chipx86

We'll get more accurate results using reviewboard.reviews.markdown_utils.render_markdown(). The extensions and settings used here are consistent between Review Board and Splat.

chipx86chipx86

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/splat.py
        setup.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/splat.py
        setup.py
    
    
  2. 
      
chipx86
  1. 
      
  2. Oof, we need to seriously give the styling on this some love.

  3. reviewboard/hostingsvcs/splat.py (Diff revision 1)
     
     
    Show all issues

    No need for "the."

    1. I don't see any grammatical issues at all.

  4. reviewboard/hostingsvcs/splat.py (Diff revision 1)
     
     
    Show all issues

    Can you use forms.SlugField instead of CharField with a validator?

  5. reviewboard/hostingsvcs/splat.py (Diff revision 1)
     
     
    Show all issues

    Mind fleshing this out to say a little more about Splat, including the URL and that it's Beanbag's bug tracker?

  6. reviewboard/hostingsvcs/splat.py (Diff revision 1)
     
     
    Show all issues

    We'll get more accurate results using reviewboard.reviews.markdown_utils.render_markdown(). The extensions and settings used here are consistent between Review Board and Splat.

  7. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/splat.py
        setup.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/splat.py
        setup.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/splat.py
        setup.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/splat.py
        setup.py
    
    
  2. reviewboard/hostingsvcs/splat.py (Diff revision 3)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  3. 
      
chipx86
  1. 
      
  2. Addressed Christian's issues

    You're not my psychiatrist!

  3. 
      
chipx86
  1. Happy after Review Bot's comment.

  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (958dd4b)