Status API part 3: Refactor entries on review detail page.
Review Request #8339 — Created Aug. 19, 2016 and submitted — Latest diff uploaded
The review detail page is huge and ugly and multi-tentacled. This change
attempts to clean things up just a little bit, by creating some classes for the
various types of "entries" (the review and change boxes).This is primarily code motion, but I did discover an obscure bug while I was
doing this related to default expansion for draft reply comments (theentry
variable was never assigned in that case, leaving it to be whatever it was
before).There's obviously a ton more that could be done here, but I want to take this
one step at a time.
Verified the appearance of the review detail page with multiple reviews,
replies, and change descriptions. Everything works as it did before.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 4. See what's changed.
reviewboard/reviews/detail.py |
---|
reviewboard/reviews/views.py |
---|
reviewboard/templates/reviews/review_detail.html |
---|
reviewboard/templates/reviews/boxes/change.html |
---|
reviewboard/templates/reviews/boxes/change.js |
---|
reviewboard/templates/reviews/boxes/review.html |
---|
reviewboard/templates/reviews/boxes/review.js |
---|