• 
      

    Prevent submission of the form in RB.JoinedGroupsView

    Review Request #8335 — Created Aug. 18, 2016 and submitted

    Information

    Review Board
    release-2.0.x
    1836491...

    Reviewers

    The RB.JoinedGroupsView automatically updates based on the contents of
    the input field in the form. Submission of this form will result in a
    CSRF error, so we prevent submission altogether.

    Manually verified the following:

    • No longer able to submit the groups form.
    • Still able to submit other preferences forms.
    Description From Last Updated

    This should have gone near the bottom, with the other private method.

    chipx86chipx86
    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.js
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (e922db6)
    chipx86
    1. 
        
    2. reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.js (Diff revision 1)
       
       
       
       
       
       
       
       
       
       
       
       
       
       
      Show all issues

      This should have gone near the bottom, with the other private method.

      1. It's already been pushed. I'll fix in a subsequent commit.

      2. This has been fixed on all branches where it was pushed.

    3.