• 
      

    Fix unit tests on release-3.0.x

    Review Request #8332 — Created Aug. 16, 2016 and submitted

    Information

    Review Board
    release-3.0.x
    f58fe0f...

    Reviewers

    This change fixes up a few test problems on release-3.0.x. These are:

    • We were still using old versions of the auth registry API, which caused some
      deprecation warnings.
    • One of those warnings was missing a trailing space on one of the concatenated
      lines, and mentioned the wrong method name.
    • The code to populate context['review_request_visit'] caused major problems
      if the viewing user was anonymous.
    • One of the tests for the action registry was broken by my recent markup
      changes.

    There's still one failing test, which checks a query count when accessing the
    review request resource. I haven't yet put any effort into tracking down how
    this regressed.

    Ran unit tests.

    Description From Last Updated

    These (and other fixes, like the bad module paths) are already covered by another change of mine. Can you revert …

    chipx86chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/accounts/backends.py
          reviewboard/admin/forms.py
          reviewboard/reviews/tests.py
          reviewboard/admin/siteconfig.py
          reviewboard/reviews/context.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/accounts/backends.py
          reviewboard/admin/forms.py
          reviewboard/reviews/tests.py
          reviewboard/admin/siteconfig.py
          reviewboard/reviews/context.py
      
      
    2. 
        
    chipx86
    1. Looks good. Just one comment to prevent an upcoming conflict.

    2. reviewboard/accounts/backends.py (Diff revision 1)
       
       
       
      Show all issues

      These (and other fixes, like the bad module paths) are already covered by another change of mine. Can you revert this so that one of us doesn't conflict with the other?

      1. Perhaps one of us should push and the other can merge.

      2. Landed.

    3. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (6f5f7bf)