• 
      

    Fix unit tests on release-2.5.x

    Review Request #8326 — Created Aug. 12, 2016 and submitted

    Information

    Review Board
    release-2.5.x
    17efbb4...

    Reviewers

    A few recent changes broke a bunch of unit tests. This change fixes them up.

    Ran unit tests.

    Description From Last Updated

    Can we set this only once? Set the local local_site_name instead to the correct value, and then set the attribute …

    chipx86chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/webapi/resources/default_reviewer.py
          reviewboard/reviews/forms.py
          reviewboard/reviews/tests.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/tests/test_review_request.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/webapi/resources/default_reviewer.py
          reviewboard/reviews/forms.py
          reviewboard/reviews/tests.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/tests/test_review_request.py
      
      
    2. 
        
    chipx86
    1. 
        
    2. reviewboard/reviews/forms.py (Diff revision 1)
       
       
       
       
       
       
       
      Show all issues

      Can we set this only once? Set the local local_site_name instead to the correct value, and then set the attribute to that?

    3. 
        
    david
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/webapi/resources/default_reviewer.py
          reviewboard/reviews/forms.py
          reviewboard/reviews/tests.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/tests/test_review_request.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/webapi/resources/default_reviewer.py
          reviewboard/reviews/forms.py
          reviewboard/reviews/tests.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/tests/test_review_request.py
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (3548961)