• 
      

    Update unit tests to reference logo.png instead of trophy.png.

    Review Request #8322 — Created Aug. 12, 2016 and submitted

    Information

    Review Board
    release-3.0.x
    15638a3...

    Reviewers

    Many of our unit tests that deal with file attachments are referencing
    trophy.png as a sample file. An upcoming change will be removing this
    file, which will break the tests. This change swaps out those references
    to use logo.png instead, in order to keep tests from failing.

    Unit tests pass.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/testing/testcase.py
          reviewboard/webapi/tests/test_file_attachment_draft.py
          reviewboard/webapi/tests/test_change.py
          reviewboard/webapi/tests/test_draft_filediff.py
          reviewboard/webapi/tests/test_screenshot.py
          reviewboard/webapi/tests/test_file_attachment.py
          reviewboard/webapi/tests/test_screenshot_draft.py
          reviewboard/attachments/tests.py
          reviewboard/webapi/tests/base.py
      
      Ignored Files:
          reviewboard/scmtools/testdata/git_binary_image_new.diff
          reviewboard/scmtools/testdata/git_binary_image_modified.diff
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/testing/testcase.py
          reviewboard/webapi/tests/test_file_attachment_draft.py
          reviewboard/webapi/tests/test_change.py
          reviewboard/webapi/tests/test_draft_filediff.py
          reviewboard/webapi/tests/test_screenshot.py
          reviewboard/webapi/tests/test_file_attachment.py
          reviewboard/webapi/tests/test_screenshot_draft.py
          reviewboard/attachments/tests.py
          reviewboard/webapi/tests/base.py
      
      Ignored Files:
          reviewboard/scmtools/testdata/git_binary_image_new.diff
          reviewboard/scmtools/testdata/git_binary_image_modified.diff
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (8e140f3)