• 
      

    Switch to the modern extensions template loader.

    Review Request #8320 — Created Aug. 5, 2016 and submitted

    Information

    Review Board
    release-2.5.x
    fd1761d...

    Reviewers

    Djblets has a more modern extensions template loader, which we weren't
    using in Review Board. This resulted in a deprecation warning. We now
    use the modern loader, preventing this warning.

    Verified the new loader was being used, and visited extension pages
    with custom templates.

    Description From Last Updated

    'django_reset' imported but unused

    reviewbotreviewbot

    'from settings_local import *' used; unable to detect undefined names

    reviewbotreviewbot

    'PIPELINE_CSS' imported but unused

    reviewbotreviewbot

    'PIPELINE_JS' imported but unused

    reviewbotreviewbot
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/settings.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/settings.py
      
      
    2. reviewboard/settings.py (Diff revision 1)
       
       
      Show all issues
       'django_reset' imported but unused
      
    3. reviewboard/settings.py (Diff revision 1)
       
       
      Show all issues
       'from settings_local import *' used; unable to detect undefined names
      
    4. reviewboard/settings.py (Diff revision 1)
       
       
      Show all issues
       'PIPELINE_CSS' imported but unused
      
    5. reviewboard/settings.py (Diff revision 1)
       
       
      Show all issues
       'PIPELINE_JS' imported but unused
      
    6. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (f39b4cd)