Fix switching between commits in the diff viewer

Review Request #8319 — Created Aug. 4, 2016 and submitted

Information

Review Board
dvcs

Reviewers

The RB.DiffViewerPageView was improperly generating the query string
for the selected commits on the page, which would lead to always
requesting commits from the server. This lead to the commit table always
resetting itself.

  • Verified switching between commits works correctly.
  • Ran JS tests.
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
david
  1. 
      
  2. Maybe use $.param instead of assembling it ourselves?

  3. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to dvcs (8b5eb6d)