• 
      

    Refactor git diff tests to use a constant on 2.0.x

    Review Request #8304 — Created July 21, 2016 and submitted

    Information

    Review Board
    release-2.0.x
    218cbc3...

    Reviewers

    The diffviewer tests that operated on git diffs were using the same diff
    defined over and over again. This patch refactors that diff out into a
    constant on the base TestCase class so that is no longer necessary. In
    addition, object SHA1s have been corrected in these diffs so that manual
    verifification against tests is easier.

    Ran unit tests.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/testing/testcase.py
          reviewboard/diffviewer/tests.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/testing/testcase.py
          reviewboard/diffviewer/tests.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (7c3ff0b)