• 
      

    Fix issues with null Profile.extra_data field.

    Review Request #8293 — Created July 18, 2016 and submitted

    Information

    Review Board
    release-2.5.x
    ed0b269...

    Reviewers

    Once upon a time, a user's Profile.extra_data defaulted to None rather than an
    empty dictionary. We recently introduced code that assumes that the field is
    non-None, and we will probably continue to add more and more such code in the
    future. This change adds some normalization to User._get_profile to make sure
    that it's not None.

    Ran unit tests. Before the fix, the new test failed. After, it succeeds.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/datagrids/tests.py
          reviewboard/accounts/models.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/datagrids/tests.py
          reviewboard/accounts/models.py
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (4f2a23a)