Summary

Fix AuthBackend unregistration

Review Request #8286 — Created July 12, 2016 and submitted July 16, 2016, 1:21 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Blocks

8287

Commit

8539b05...

Reviewers

Groups

reviewboard

People

Description

The refactoring of the AuthBackend code to use a registry mistakenly
used Registry.unregister_item(), which wasn't the method name that
was decided on (Registry.unregister()). This has been fixed and unit
tests have been added to ensure registration and unregistration through
the register_auth_backend and unregister_auth_backend methods works
correctly.

In addition, the AuthBackendRegistry.get method was removed becuase
the AuthBackendRegistry already inherits from
ExceptionFreeGetterMixin, which provides the same behaviour.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
The removal of this function isn't discussed in your description of the change.	david	July 14, 2016, 5:38 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/accounts/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/backends.py
    reviewboard/accounts/tests.py

reviewboard/accounts/backends.py (Diff revision 1)
The issue has been resolved. Show all issues
```
The removal of this function isn't discussed in your description of the change.
```
1. brennie July 14, 2016, 5:38 p.m.
  Oops! Updated.

Description:: The refactoring of the AuthBackend code to use a registry mistakenly
used Registry.unregister_item(), which wasn't the method name that
was decided on (Registry.unregister()). This has been fixed and unit
tests have been added to ensure registration and unregistration through
the register_auth_backend and unregister_auth_backend methods works
correctly.
+
+
In addition, the AuthBackendRegistry.get method was removed becuase
+ the AuthBackendRegistry already inherits from
+ ExceptionFreeGetterMixin, which provides the same behaviour.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (f8fc559)

		The refactoring of the AuthBackend code to use a registry mistakenly
		used `Registry.unregister_item()`, which wasn't the method name that
		was decided on (`Registry.unregister()`). This has been fixed and unit
		tests have been added to ensure registration and unregistration through
		the `register_auth_backend` and `unregister_auth_backend` methods works
		correctly.
	+
	+	In addition, the `AuthBackendRegistry.get` method was removed becuase
	+	the `AuthBackendRegistry` already inherits from
	+	`ExceptionFreeGetterMixin`, which provides the same behaviour.