Fix some JS issues on the dvcs branch
Review Request #8282 — Created July 11, 2016 and submitted
The dvcs branch had a few typos that slipped through review; this patch
addresses those.In addition, two bugs have been fixed. The first is that the expanded
commit description would show if the description contained a trailing
newline. Now, we trim the description and summary before comparing them
to determine if we should show the extended description.The second bug is that the diff viewer would attempt to view the commit
range of an interdiff, which is invalid. Now, we only inspect the commit
range when interdiffs are not selected.
The above issues no longer occur.
| Description | From | Last Updated |
|---|---|---|
|
Trailing whitespace. |
 david
|
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/diffviewer/models/diffCommitModel.es6.js reviewboard/static/rb/js/diffviewer/views/diffCommitIndexView.es6.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js