Fix the displayed line numbers in e-mails with filtered interdiffs.
Review Request #8246 — Created June 16, 2016 and submitted
The new code for calculating displayed line numbers in e-mails didn't take into account that filtered interdiffs could result in equal chunks without line numbers. It's been updated to check whether there are line numbers in the appropriate side of the chunk before considering that side valid. Unit tests have been updated for these conditions.
Unit tests pass. Before, the new tests were failing with the same error
we saw in production with the same conditions.
Tool: Pyflakes Processed Files: reviewboard/reviews/templatetags/tests.py reviewboard/diffviewer/tests.py reviewboard/diffviewer/diffutils.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/templatetags/tests.py reviewboard/diffviewer/tests.py reviewboard/diffviewer/diffutils.py