• 
      

    SubmitterColumn now links to local site user view when appropriate

    Review Request #8241 — Created June 12, 2016 and submitted

    Information

    Review Board
    release-2.5.x
    e1e6472...

    Reviewers

    In Review Board 2.5, the datagrids were redesigned. However, this broke
    the existing behaviour of the submitter column linking to the local site
    user page when it was viewed under a local site. This patch fixes that
    behaviour.

    • Tested this patch with a local site. Verified that the link in the
      SubmitterColumn in the datagrid was to the user view on the local
      site.
    • Verified that the link goes to the global user view when not viewed on
      a local site.
    • Ran unit tests.
    Description From Last Updated

    "we're" should be "were" in the description.

    chipx86chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/datagrids/columns.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/datagrids/columns.py
      
      
    2. 
        
    brennie
    chipx86
    1. 
        
    2. Show all issues

      "we're" should be "were" in the description.

    3. 
        
    brennie
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (e95cacc)