Summary

Fix missing data for file attachment thumbnails for change descriptions.

Review Request #8232 — Created June 10, 2016 and submitted June 10, 2016, 3:10 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

d6213ed...

Reviewers

Groups

reviewboard

People

Description

If a file attachment thumbnail needed to make use of the User currently
browsing the page, it could break when rendering change descriptions, as
the request variable wasn't being provided to the template context.
The implementation would only see an empty string. This was causing
problems with Power Pack's PDF thumbnail support.

We now simply ensure that the request is passed in as part of the
context.

Testing Done

Tested against a PDF thumbnail on a change description. I didn't see any
errors.

Had a customer test this as well, and he verified the errors went away on
his end.

Issues

Description	From	Last Updated
Wouldn't it be better to make this a RequestContext?	david	June 10, 2016, 3:02 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/builtin_fields.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/builtin_fields.py

reviewboard/reviews/builtin_fields.py (Diff revision 1)

The issue has been dropped. Show all issues

Wouldn't it be better to make this a RequestContext?

chipx86 June 10, 2016, 3:01 p.m.

RequestContext is great when you really need the template to have access to not only the request but any context processors that are registered. However, it's pretty slow, as it results in a lot of extra processing up-front, both internally to the class and by invoking all the context processors. Since we have a very limited template here (it's baked into Review Board, and not something overridden by extensions), we don't need to deal with all that extra processing.

david June 10, 2016, 3:02 p.m.
```
Sounds good.
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (441ab30)