• 
      

    Fix bugs bugs with local sites.

    Review Request #8224 — Created June 8, 2016 and submitted

    Information

    Review Board
    release-2.5.x
    ac80af9...

    Reviewers

    The bugs field on a review request had several bugs when using local sites. The
    first of these is that we were passing in the arguments to local_site_reverse
    as a tuple, but in the case where there's a local site, that gets appended to a
    list (which doesn't work). Changing this to be a list fixes this bug. Second,
    the bug_url and bug_infobox views took a local_site argument but didn't
    add the necessary decorators to translate the local_site_name parameter into
    a real object (and do associated access checks).

    Bugs.

    Set the bugs field on a review request on a local site. Saw that I could then
    re-load the page and see the bugs listed. Clicked on a bug link and saw that I
    was correctly redirected. Hovered over a link and saw a request to the infobox
    URL that was correctly handled.

    Description From Last Updated

    'ChangeDescription' imported but unused

    reviewbotreviewbot
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/builtin_fields.py
          reviewboard/reviews/views.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/builtin_fields.py
          reviewboard/reviews/views.py
      
      
    2. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
       'ChangeDescription' imported but unused
      
    3. 
        
    david
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/builtin_fields.py
          reviewboard/reviews/views.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/builtin_fields.py
          reviewboard/reviews/views.py
      
      
    2. 
        
    brennie
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (054a411)