Clean up the hosting service registry
Review Request #8217 — Created June 3, 2016 and submitted
The hosting services registry was not ported to
djblets.registries.Registry
as cleanly as it should have been. As a
result, the "Add repository" form broke, due to missing information on
hosting services. In addition, Review Board 2.0.x introduced a
hosting_service_id
attribute which mirrored theid
attribute that
3.0.x introduced. We now only use thehosting_service_id
attribute.The "Add repository" form now works correctly and no more errors are
triggered in the log.
- Ran unit tests.
- Successfully added a repository in the "Add repository" form.
Description | From | Last Updated |
---|---|---|
Col: 31 E128 continuation line under-indented for visual indent |
reviewbot | |
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot | |
The things in the regexes there are safe, but we should escape the hosting service ID (which we weren't doing … |
chipx86 | |
Looks like a blank line was added. |
chipx86 | |
undefined name 're' |
reviewbot | |
Just to make the tuple super obvious, how about putting the closing paren on the next line? hosting_service_choices.append( (hosting_service.hosting_service_id, hosting_service.name) … |
david | |
Same here. |
david | |
It was this way before, but we should pass in hosting_service.hosting_service_id and e as arguments rather than doing the format … |
david |
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/tests/test_hosting_service_account.py reviewboard/scmtools/forms.py reviewboard/webapi/tests/test_hosting_service.py reviewboard/webapi/tests/urls.py reviewboard/hostingsvcs/service.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/tests/test_hosting_service_account.py reviewboard/scmtools/forms.py reviewboard/webapi/tests/test_hosting_service.py reviewboard/webapi/tests/urls.py reviewboard/hostingsvcs/service.py
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/tests/test_hosting_service_account.py reviewboard/scmtools/forms.py reviewboard/webapi/tests/test_hosting_service.py reviewboard/webapi/tests/urls.py reviewboard/hostingsvcs/service.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/tests/test_hosting_service_account.py reviewboard/scmtools/forms.py reviewboard/webapi/tests/test_hosting_service.py reviewboard/webapi/tests/urls.py reviewboard/hostingsvcs/service.py
-
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/tests/test_hosting_service_account.py reviewboard/scmtools/forms.py reviewboard/webapi/tests/test_hosting_service.py reviewboard/webapi/tests/urls.py reviewboard/hostingsvcs/service.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/tests/test_hosting_service_account.py reviewboard/scmtools/forms.py reviewboard/webapi/tests/test_hosting_service.py reviewboard/webapi/tests/urls.py reviewboard/hostingsvcs/service.py
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/tests/test_hosting_service_account.py reviewboard/scmtools/forms.py reviewboard/webapi/tests/test_hosting_service.py reviewboard/webapi/tests/urls.py reviewboard/hostingsvcs/service.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/tests/test_hosting_service_account.py reviewboard/scmtools/forms.py reviewboard/webapi/tests/test_hosting_service.py reviewboard/webapi/tests/urls.py reviewboard/hostingsvcs/service.py